fix: reuse session ID in external storage example #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous example generated a new UUID on every wrap() call. This breaks RSC environments where cookies cannot be updated, causing session loss when the cookie still contains the old ID. Updated the MemorySessionWrapper example to store and reuse the session ID from unwrap(), ensuring the cookie value remains stable while external storage data can be updated.
Deploying logto-docs-tutorials with
|
| Latest commit: |
6d9350c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://78a8f900.logto-docs-tutorials.pages.dev |
| Branch Preview URL: | https://fix-session-wrapper-reuse-id.logto-docs-tutorials.pages.dev |
Deploying logto-docs with
|
| Latest commit: |
6d9350c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aff4410a.logto-docs.pages.dev |
| Branch Preview URL: | https://fix-session-wrapper-reuse-id.logto-docs.pages.dev |
xiaoyijun
approved these changes
Dec 31, 2025
Expanded the tip about RSC not being able to persist refreshed tokens. Added clear solutions: using client components with Server Actions, or using external session storage with sessionWrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
MemorySessionWrapperexample to reuse session IDs instead of generating a new UUID on everywrap()call.Problem
The previous example generated a new
randomUUID()on everywrap()call. This breaks in environments where cookies cannot be updated (e.g., React Server Components), because:wrap()saves data with a new session IDsetCookie()is skipped (RSC is read-only)