Add a test for histogram conversion out-of-range#17
Open
Conversation
8naama
reviewed
Mar 16, 2025
Comment on lines
+342
to
+379
| func TestConvertFromHistogramIndexOutOfRange(t *testing.T) { | ||
| exporter := Exporter{ | ||
| config: validConfig, | ||
| } | ||
|
|
||
| // Create a histogram metric with an invalid bucket count to simulate the out-of-range index | ||
| histogramMetric := &metricdata.ResourceMetrics{ | ||
| ScopeMetrics: []metricdata.ScopeMetrics{ | ||
| { | ||
| Metrics: []metricdata.Metrics{ | ||
| { | ||
| Name: "test_histogram", | ||
| Data: metricdata.Histogram[int64]{ | ||
| DataPoints: []metricdata.HistogramDataPoint[int64]{ | ||
| { | ||
| Count: 3600, | ||
| Sum: 15, | ||
| BucketCounts: []uint64{1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, // 15 buckets // 16 buckets | ||
| Bounds: []float64{0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2500, 5000, 7500, 10000}, // 15 bounds | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| err := func() (err error) { | ||
| defer func() { | ||
| if r := recover(); r != nil { | ||
| err = fmt.Errorf("panic occurred: %v", r) | ||
| } | ||
| }() | ||
| _, err = exporter.ConvertToTimeSeries(histogramMetric) | ||
| return err | ||
| }() | ||
|
|
Contributor
There was a problem hiding this comment.
I think this should be a test case of TestConvertToTimeSeries and not a standalone test function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test for
index out of range [N] with length Npanic that used to occur when converting histogram metric where bucket count and bounds are in the same length.What type of PR is this?
(check all applicable)
Added tests?