APPZ-2108 AccoundId based datasource - migration support#3
Merged
Gavriel-M merged 1 commit intomain-logziofrom Mar 2, 2026
Merged
Conversation
Signed-off-by: gavriel-m <MGavrielG@Gmail.com>
galangel
approved these changes
Mar 1, 2026
Collaborator
galangel
left a comment
There was a problem hiding this comment.
Some questions that you need to be able to answer before merging:
- What happens when there are two accounts with the same name? Is it possible?
- Are you comparing case sensitive? ( regarding prev question )
- Is this a one-time pass, or every visit will require this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where renaming an account (datasource) could break dashboards by improving how datasource variables are resolved and matched. The changes enhance the robustness of datasource selection by ensuring that both display names and selector names are considered when resolving variables, making the component more resilient to renames.
Improvements to datasource variable resolution:
DatasourceSelectto check both the display name and the selector name, ensuring that dashboards continue to function even if a datasource is renamed.datasourceSelectValueToSelectorfunction to match datasource variables using both the datasource's display name and selector name, improving reliability when resolving selectors from variables.Code cleanup:
parseVariablesimport fromDatasourceSelect.tsx.