Optimize computeScore

[jvandreae]

Perhaps it's this way because it was ported, but it should be possible to optimize computeScore a bit.

Not sure how efficient they are but I didn't try named parameters for clarity because the repo targets PHP 7.

Not using type signatures seems to save a fair bit of time 💀

Script:

<?php

require_once './vendor/autoload.php';

$arr = [];
$seed = 1234;
$r = new \Random\Randomizer(new \Random\Engine\Mt19937($seed));
$chars = 'abcdefghijklmnopqrstuvwxyz';

for ($i = 0; $i < 100000; $i++) {
    $key = '';
    for ($j = 0; $j < 200; $j++) {
        $key .= $chars[$r->getInt(0, strlen($chars) - 1)];
    }
    $arr[] = [
        'key' => $key,
    ];
}

$fuse = new \Fuse\Fuse($arr, [
    'isCaseSensitive' => true,
    'includeScore' => true,
    'minMatchCharLength' => 2,
    'shouldSort' => true,
    'keys' => ['key'],
    'threshold' => 0.25,
]);

if (function_exists('spx_profiler_start')) {
    spx_profiler_start();
}
try {
    $start = microtime(true);
    $results = $fuse->search('test');
    $end = microtime(true);
    printf("%g\n", $end-$start);
} finally {
    if (function_exists('spx_profiler_stop')) {
        spx_profiler_stop();
    }
}

Before:

$ SPX_BUILTINs=1 SPX_ENABLED=1 SPX_REPORT=flat SPX_FP_LIVE=1 SPX_AUTO_START=0 php -d opcache.enable_cli=1 test.php

*** SPX Report ***

Global stats:

  Called functions    :     2.0M
  Distinct functions  :       27

  Wall time           :    2.76s
  ZE memory usage     :   59.2KB

Flat profile:

 Wall time           | ZE memory usage     |
 Inc.     | *Exc.    | Inc.     | Exc.     | Called   | Function
----------+----------+----------+----------+----------+----------
    2.57s |    1.89s |       0B |  525.1MB |   100.0K | Fuse\Search\Bitap\search
  484.0ms |  484.0ms | -537.9MB | -537.9MB |     1.5M | Fuse\Search\Bitap\computeScore
  197.0ms |  197.0ms |   12.8MB |   12.8MB |   100.0K | Fuse\Search\Bitap\convertMaskToIndices
  649.7us |  630.4us |    1.3KB |    1.3KB |        4 | 1@Composer\Autoload\{closure}
   44.1us |   40.2us |   15.1KB |   15.1KB |       41 | Fuse\Core\{closure}
   33.7us |   33.7us |     432B |     432B |        4 | Composer\Autoload\ClassLoader::findFileWithExtension
   14.2us |   14.2us |       0B |       0B |      139 | Fuse\Helpers\sort
   53.0us |    8.9us |   16.0KB |     960B |        1 | Fuse\Core\format
   41.4us |    6.8us |     336B |       0B |        1 | /home/john/Code/Fuse/src/Search/Bitap/BitapSearch.php
  441.5us |    4.0us |    2.8KB |     144B |        1 | Fuse\Core\Register::createSearcher

$ php -d opcache.enable_cli=1 -d opcache.jit=1255 -d opcache.jit_buffer_size=200M -d memory_limit=-1 test.php
      0.837517

After:

$ SPX_BUILTINs=1 SPX_ENABLED=1 SPX_REPORT=flat SPX_FP_LIVE=1 SPX_AUTO_START=0 php -d opcache.enable_cli=1 test.php

*** SPX Report ***

Global stats:

  Called functions    :     2.0M
  Distinct functions  :       27

  Wall time           :    2.41s
  ZE memory usage     :   59.2KB

Flat profile:

 Wall time           | ZE memory usage     |
 Inc.     | *Exc.    | Inc.     | Exc.     | Called   | Function
----------+----------+----------+----------+----------+----------
    2.23s |    1.79s |       0B |  -12.8MB |   100.0K | Fuse\Search\Bitap\search
  247.1ms |  247.1ms |       0B |       0B |     1.5M | Fuse\Search\Bitap\computeScore
  197.0ms |  197.0ms |   12.8MB |   12.8MB |   100.0K | Fuse\Search\Bitap\convertMaskToIndices
  661.9us |  639.6us |    1.3KB |    1.3KB |        4 | 1@Composer\Autoload\{closure}
   32.1us |   32.1us |     432B |     432B |        4 | Composer\Autoload\ClassLoader::findFileWithExtension
   33.4us |   29.8us |   15.1KB |   15.1KB |       41 | Fuse\Core\{closure}
   14.2us |   14.2us |       0B |       0B |      139 | Fuse\Helpers\sort
   44.0us |   10.3us |     336B |       0B |        1 | /home/john/Code/Fuse/src/Search/Bitap/BitapSearch.php
   40.7us |    7.3us |   16.0KB |     960B |        1 | Fuse\Core\format
  446.0us |    3.9us |    2.8KB |     144B |        1 | Fuse\Core\Register::createSearcher

$ php -d opcache.enable_cli=1 -d opcache.jit=1255 -d opcache.jit_buffer_size=200M -d memory_limit=-1 test.php
  0.737639