Skip to content

feat(AP-2596): Introduce WS room for "shopify"#51

Closed
Drodevbar wants to merge 1 commit intomainfrom
feat/AP-2596-add-shopify-websocket-room
Closed

feat(AP-2596): Introduce WS room for "shopify"#51
Drodevbar wants to merge 1 commit intomainfrom
feat/AP-2596-add-shopify-websocket-room

Conversation

@Drodevbar
Copy link
Contributor

No description provided.

export: PROJECT_ID_SCHEMA,
translation: PROJECT_ID_SCHEMA,
segment: PROJECT_ID_SCHEMA,
shopify: PROJECT_ID_SCHEMA,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for what events we will use this room?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far for categories and items status changes on Content Manager view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dosexe Perhaps a better name would be content-manager then? It's more generic and better describes the purpose. WDYT?

Copy link
Collaborator

@Dosexe Dosexe Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that was my next question, why we are introducing shopify context in autopilot somewhere outside of backend-shopify. content-manager sounds better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will close this PR and create a new one - for content-manager (I don't want to have shopify infix in branch name)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freiondrej-lokalise @Dosexe please see this one 🙇 #52

@Drodevbar
Copy link
Contributor Author

See: #51 (comment)

@Drodevbar Drodevbar closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants