Merge pull request #557 from RuiBandarra/patch-1

lokesh · web-flow · commit fbd39fe7825d · 2019-04-21T21:48:10.000-07:00
Bugfix - MaxHeight wouldn't work.
diff --git a/src/js/lightbox.js b/src/js/lightbox.js
@@ -323,7 +323,7 @@
         if (self.options.maxWidth && self.options.maxWidth < maxImageWidth) {
           maxImageWidth = self.options.maxWidth;
         }
-        if (self.options.maxHeight && self.options.maxHeight < maxImageWidth) {
+        if (self.options.maxHeight && self.options.maxHeight < maxImageHeight) {
           maxImageHeight = self.options.maxHeight;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,7 @@`
`323`	`323`	`if (self.options.maxWidth && self.options.maxWidth < maxImageWidth) {`
`324`	`324`	`maxImageWidth = self.options.maxWidth;`
`325`	`325`	`}`
`326`		`- if (self.options.maxHeight && self.options.maxHeight < maxImageWidth) {`
	`326`	`+ if (self.options.maxHeight && self.options.maxHeight < maxImageHeight) {`
`327`	`327`	`maxImageHeight = self.options.maxHeight;`
`328`	`328`	`}`
`329`	`329`