Skip to content

Bug fix for onload race condition #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Bug fix for onload race condition #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/js/lightbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

function Lightbox(options) {
this.album = [];
this.albumResetCounter = 0;
this.currentImageIndex = void 0;
this.init();

Expand Down Expand Up @@ -207,6 +208,7 @@

this.sizeOverlay();

this.albumResetCounter++;
this.album = [];
var imageNumber = 0;

Expand Down Expand Up @@ -265,6 +267,7 @@
// Hide most UI elements in preparation for the animated resizing of the lightbox.
Lightbox.prototype.changeImage = function(imageNumber) {
var self = this;
var albumResetCounter = this.albumResetCounter;

this.disableKeyboardNav();
var $image = this.$lightbox.find('.lb-image');
Expand All @@ -287,6 +290,9 @@
var windowHeight;
var windowWidth;

if (albumResetCounter !== self.albumResetCounter)
return;

$image.attr({
'alt': self.album[imageNumber].alt,
'src': self.album[imageNumber].link
Expand Down