-
-
Notifications
You must be signed in to change notification settings - Fork 3
BCD-esque fiction data for api.Hightlight.type #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| { | ||
| "api": { | ||
| "Highlight": { | ||
| "type": { | ||
| "__compat": { | ||
| "description": "Semantic highlight type exposed to users", | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/Highlight/type", | ||
| "spec_url": "https://drafts.csswg.org/css-highlight-api-1/#highlight-types", | ||
| "tags": [ | ||
| "web-features:highlight" | ||
| ], | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "105", | ||
| "nvda": { | ||
| "version_added": false, | ||
| "devices": ["Linux", "Windows", "macOS"] | ||
| }, | ||
| "jaws": { | ||
| "version_added": false, | ||
| "devices": ["Linux", "Windows", "macOS"] | ||
| } | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "140", | ||
| "nvda": { | ||
| "version_added": "1.4", | ||
| "devices": ["Linux", "Windows", "macOS"] | ||
| }, | ||
| "voiceover": { | ||
| "version_added": "26", | ||
| "devices": ["macOS"], | ||
|
||
| "partial_implementation": true, | ||
| "notes": "Truncates the line and only starts reading from the highlight." | ||
| } | ||
| }, | ||
|
||
| "safari": { | ||
| "version_added": "17.2", | ||
| "nvda": { | ||
| "version_added": false, | ||
| "devices": ["Linux", "Windows", "macOS"] | ||
| }, | ||
| "jaws": { | ||
| "version_added": false, | ||
| "devices": ["Linux", "Windows", "macOS"] | ||
| }, | ||
| "voiceover": { | ||
| "version_added": "26", | ||
| "devices": ["macOS"], | ||
| "partial_implementation": true, | ||
| "notes": "Truncates the line and only starts reading from the highlight." | ||
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api.Hightlight.type is a key that BCD is using already. Do we want this sort of key matching to indicate that this complements the BCD information?
Consumers would query:
bcd.api.Hightlight.type
acd.api.Hightlight.type
Or should we instead always create unique keys?
bcd.api.Hightlight.type
acd.api.Hightlight.type_exposure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd need to understand more about why the keys are the way they are and if ACD loses/gains anything by adopting the same structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think by sticking roughly to BCD's structure you gain some sort of belonging for the data. The is maybe not so much of a concern now that we can also tag the data with a web-feature id, but it may still be useful for data consumers. BCD does this so you do queries like "http.headers.*" and then get the BCD for all HTTP headers.