Skip to content

Comments

fix(grpc): disable grpc service discovery to prevent dns flooding#766

Merged
derekbit merged 1 commit intolonghorn:masterfrom
COLDTURNIP:12521-disable_grpc_service_discovery
Jan 23, 2026
Merged

fix(grpc): disable grpc service discovery to prevent dns flooding#766
derekbit merged 1 commit intolonghorn:masterfrom
COLDTURNIP:12521-disable_grpc_service_discovery

Conversation

@COLDTURNIP
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#12521

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@mergify
Copy link

mergify bot commented Jan 22, 2026

This pull request is now in conflict. Could you fix it @COLDTURNIP? 🙏

@COLDTURNIP
Copy link
Contributor Author

PR created by OpenCode.

@COLDTURNIP COLDTURNIP requested a review from derekbit January 22, 2026 09:30
@COLDTURNIP COLDTURNIP force-pushed the 12521-disable_grpc_service_discovery branch from a89dd9e to 0c8a2af Compare January 22, 2026 09:34
@COLDTURNIP
Copy link
Contributor Author

grpc.WithNoProxy is removed accidentally by the agent, fixing.

@COLDTURNIP COLDTURNIP force-pushed the 12521-disable_grpc_service_discovery branch from 0c8a2af to a7e2eb5 Compare January 22, 2026 09:46
@derekbit
Copy link
Member

@COLDTURNIP DCO failed

@derekbit derekbit force-pushed the 12521-disable_grpc_service_discovery branch from a7e2eb5 to 275842a Compare January 23, 2026 00:43
Copy link
Contributor

@c3y1huang c3y1huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for DCO to be fixed.

@COLDTURNIP COLDTURNIP force-pushed the 12521-disable_grpc_service_discovery branch from 275842a to 9bc89be Compare January 23, 2026 02:05
longhorn-12521

Signed-off-by: Raphanus Lo <yunchang.lo@suse.com>
@derekbit derekbit force-pushed the 12521-disable_grpc_service_discovery branch from 9bc89be to aeb13bc Compare January 23, 2026 02:20
@derekbit
Copy link
Member

@mergify backport v1.10.x v1.11.x

@mergify
Copy link

mergify bot commented Jan 23, 2026

backport v1.10.x v1.11.x

✅ Backports have been created

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants