Final code by GrahamSH-LLK · Pull Request #12 · longmetal7127/TinyElvis

GrahamSH-LLK · 2025-05-28T01:58:18Z

No description provided.

… and smoothly pull into setpoint and revert source setpoint changes

…nto whyyyyyy

Copilot

Pull Request Overview

Refactors path planning and integrates system-identification routines, while enhancing subsystem functionality and tuning.

Simplified RepulsorFieldPlanner API and removed deprecated network-table toggles.
Exposed open-loop interfaces in SwerveModule and added drive/steer SysId routines in DriveTrain.
Expanded LED subsystem with multiple flag-based patterns and introduced command wrappers.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
RepulsorFieldPlanner.java	Unified force calculation, removed NT listeners, simplified sample API
SwerveModule.java	Made motors public, added `sysid` flag and open-loop methods
LED.java	Introduced `LEDState` enum, randomized and flag patterns
DriveTrain.java	Added unit-safe SysId routines, updated autoAlign and stop command
Swerve.java	Updated max speed, feedforward constants, PID tuning
Robot.java	Registered SysId auto commands and LED-wrapped commands

Comments suppressed due to low confidence (3)

src/main/java/frc/robot/subsystems/SwerveModule.java:66

[nitpick] The field name sysid doesn’t follow typical camelCase or boolean naming conventions. Consider renaming it to isSysIdMode or sysIdEnabled for clarity.

public boolean sysid = false;

src/main/java/frc/robot/subsystems/DriveTrain.java:683

ChassisSpeeds is used but not imported in this file, which will lead to a compile error. Add import edu.wpi.first.math.kinematics.ChassisSpeeds;.

return runOnce(() -> { this.setChassisSpeeds(new ChassisSpeeds(0, 0, 0)); });

src/main/java/frc/robot/subsystems/DriveTrain.java:215

[nitpick] The delay 0.04 seconds is a magic number. Extract it into a named constant or add a comment explaining its purpose.

Commands.sequence(Commands.waitSeconds(0.04),Commands.waitUntil(driveTrain.atSetpoint))

Copilot · 2025-05-28T02:00:15Z

src/main/java/frc/robot/util/RepulsorFieldPlanner.java

  Force getObstacleForce(Translation2d curLocation, Translation2d target) {
    var force = Force.kZero;
-    for (Obstacle obs : FIELD_OBSTACLES) {
+    for (Obstacle obs : fixedObstacles) {


fixedObstacles is initialized as an empty list and never populated, so getObstacleForce (and walls) will always return zero. Consider initializing fixedObstacles with FIELD_OBSTACLES and WALLS or iterating over those constants directly.

it's populated in ctor

@copilot it's populated in ctor, are you sure?

Copilot · 2025-05-28T02:00:16Z

src/main/java/frc/robot/subsystems/SwerveModule.java

+        public final SparkFlex m_drivingSpark;
+        public final SparkMax m_turningSpark;


[nitpick] Exposing the motor controllers as public fields breaks encapsulation. Consider keeping them private and providing getters or higher-level methods instead.

Suggested change

public final SparkFlex m_drivingSpark;

public final SparkMax m_turningSpark;

private final SparkFlex m_drivingSpark;

private final SparkMax m_turningSpark;

Copilot · 2025-05-28T02:00:16Z

src/main/java/frc/robot/subsystems/LED.java

+    AddressableLEDBufferView m_right = m_ledBuffer.createView(0, 11);
+    AddressableLEDBufferView m_left = m_ledBuffer.createView(12, 22);
+    AddressableLEDBufferView m_middle = m_ledBuffer.createView(23, 34);


[nitpick] The views m_right, m_left, and m_middle are created but never used in periodic(). Remove them or apply patterns to these views to avoid unused code.

Suggested change

AddressableLEDBufferView m_right = m_ledBuffer.createView(0, 11);

AddressableLEDBufferView m_left = m_ledBuffer.createView(12, 22);

AddressableLEDBufferView m_middle = m_ledBuffer.createView(23, 34);

// Removed unused views: m_right, m_left, and m_middle

Copilot · 2025-05-28T02:00:16Z

src/main/java/frc/robot/constants/Swerve.java

          ModuleConstants.kDrivingMotorReduction;
      double turningFactor = 2 * Math.PI;
-      double drivingVelocityFeedForward = 1 / ModuleConstants.kDriveWheelFreeSpeedRps;
+      double drivingVelocityFeedForward = 2.0548;


[nitpick] The hard-coded 2.0548 is a magic literal. Document its derivation or compute it explicitly to improve clarity.

Suggested change

double drivingVelocityFeedForward = 2.0548;

// Calculate driving velocity feed-forward gain based on motor free speed and wheel diameter.

double motorFreeSpeedMetersPerSecond = (MotorConstants.kFreeSpeedRpm / 60.0) *

(ModuleConstants.kWheelDiameterMeters * Math.PI / ModuleConstants.kDrivingMotorReduction);

double drivingVelocityFeedForward = 1.0 / motorFreeSpeedMetersPerSecond; // Inverse of max speed

// Explanation:

// - MotorConstants.kFreeSpeedRpm: Free speed of the motor in RPM.

// - ModuleConstants.kWheelDiameterMeters: Diameter of the wheel in meters.

// - ModuleConstants.kDrivingMotorReduction: Gear reduction factor for the driving motor.

// - motorFreeSpeedMetersPerSecond: Maximum speed of the robot in meters per second.

// - drivingVelocityFeedForward: Feed-forward gain calculated as the inverse of max speed.

Copilot

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-28T16:51:28Z

src/main/java/frc/robot/subsystems/SwerveModule.java

+        public final SparkFlex m_drivingSpark;
+        public final SparkMax m_turningSpark;


Making motor controllers public breaks encapsulation and exposes internal implementation details. Consider providing controlled access through getter methods instead of direct public field access.

Copilot · 2025-09-28T16:51:28Z

src/main/java/frc/robot/subsystems/SwerveModule.java

+         * @param desiredState Desired state with speed and angle.
+         */
+        public void setDesiredState(SwerveModuleState desiredState) {
+                if(sysid) return;


Missing space after 'if' keyword violates standard Java formatting conventions. Should be 'if (sysid) return;'.

Suggested change

if(sysid) return;

if (sysid) return;

Copilot · 2025-09-28T16:51:28Z

src/main/java/frc/robot/subsystems/DriveTrain.java


  // The gyro sensor
-  public final AHRS m_gyro = new AHRS(AHRS.NavXComType.kMXP_SPI);
+  public final AHRS m_gyro = new AHRS(AHRS.NavXComType.kUSB1);


Changing gyro connection from kMXP_SPI to kUSB1 is a significant hardware configuration change that should be documented or made configurable, as it affects robot hardware setup.

Suggested change

public final AHRS m_gyro = new AHRS(AHRS.NavXComType.kUSB1);

/**

* Hardware configuration: Set the NavX connection type here.

* If you change the physical connection (e.g., from USB to MXP), update this constant.

* Possible values: AHRS.NavXComType.kUSB1, AHRS.NavXComType.kMXP, etc.

*/

private static final AHRS.NavXComType GYRO_PORT_TYPE = AHRS.NavXComType.kUSB1;

public final AHRS m_gyro = new AHRS(GYRO_PORT_TYPE);

longmetal-drivestation and others added 10 commits March 29, 2025 12:27

whyyyyy

bed95c3

hola

01bb924

blup

48c9f01

cthar end

87d7e3a

hola

786e45b

change gear ratio

72eee64

fix autoalign and auto and gear ratio and switch to new repulsor impl…

ed7c82c

… and smoothly pull into setpoint and revert source setpoint changes

Merge branch 'whyyyyyy' of https://github.com/longmetal7127/2025bot i…

625c940

…nto whyyyyyy

lmfao easy fix

7f4b4a2

yey

454e362

Copilot AI review requested due to automatic review settings May 28, 2025 01:58

Copilot AI reviewed May 28, 2025

View reviewed changes

GrahamSH-LLK requested a review from Copilot September 28, 2025 16:50

Copilot AI reviewed Sep 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Final code#12

Final code#12
GrahamSH-LLK wants to merge 10 commits intomainfrom
whyyyyyy

GrahamSH-LLK commented May 28, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 28, 2025

Uh oh!

GrahamSH-LLK Sep 28, 2025

Uh oh!

GrahamSH-LLK Sep 28, 2025

Uh oh!

Copilot AI May 28, 2025

Uh oh!

Copilot AI May 28, 2025

Uh oh!

Copilot AI May 28, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 28, 2025

Uh oh!

Copilot AI Sep 28, 2025

Uh oh!

Copilot AI Sep 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		public final SparkFlex m_drivingSpark;
		public final SparkMax m_turningSpark;

-      double drivingVelocityFeedForward = 2.0548;
+      // Calculate driving velocity feed-forward gain based on motor free speed and wheel diameter.
+      double motorFreeSpeedMetersPerSecond = (MotorConstants.kFreeSpeedRpm / 60.0) *
+          (ModuleConstants.kWheelDiameterMeters * Math.PI / ModuleConstants.kDrivingMotorReduction);
+      double drivingVelocityFeedForward = 1.0 / motorFreeSpeedMetersPerSecond; // Inverse of max speed
+      // Explanation:
+      // - MotorConstants.kFreeSpeedRpm: Free speed of the motor in RPM.
+      // - ModuleConstants.kWheelDiameterMeters: Diameter of the wheel in meters.
+      // - ModuleConstants.kDrivingMotorReduction: Gear reduction factor for the driving motor.
+      // - motorFreeSpeedMetersPerSecond: Maximum speed of the robot in meters per second.
+      // - drivingVelocityFeedForward: Feed-forward gain calculated as the inverse of max speed.

-  public final AHRS m_gyro = new AHRS(AHRS.NavXComType.kUSB1);
+  /**
+   * Hardware configuration: Set the NavX connection type here.
+   * If you change the physical connection (e.g., from USB to MXP), update this constant.
+   * Possible values: AHRS.NavXComType.kUSB1, AHRS.NavXComType.kMXP, etc.
+   */
+  private static final AHRS.NavXComType GYRO_PORT_TYPE = AHRS.NavXComType.kUSB1;
+  public final AHRS m_gyro = new AHRS(GYRO_PORT_TYPE);

Conversation

GrahamSH-LLK commented May 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

GrahamSH-LLK Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

GrahamSH-LLK Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants