Display only selected nozzle efficiency in ship mass charts#84
Merged
lookbusy1344 merged 3 commits intomainfrom Dec 22, 2025
Merged
Display only selected nozzle efficiency in ship mass charts#84lookbusy1344 merged 3 commits intomainfrom
lookbusy1344 merged 3 commits intomainfrom
Conversation
Modified data generation and chart creation to accept nozzle efficiency parameter and display only the selected efficiency profile instead of showing all 4 profiles (70%, 75%, 80%, 85%). Co-authored-by: lookbusy1344 <3680611+lookbusy1344@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update ship mass over time chart to single line
Display only selected nozzle efficiency in ship mass charts
Dec 22, 2025
The code was using pionRocketFuelFraction() which returns fractions (0.0-1.0) but treating them as percentages (0-100), causing mass remaining to display ~99-100% instead of realistic values. Fixed by subtracting fuel fraction from 1, then multiplying by 100 to convert to percentage. Added tests using TDD to verify mass decreases significantly over time and monotonically. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Ship mass over time" charts on Constant Acceleration and Flip tabs displayed all 4 nozzle efficiency profiles (70%, 75%, 80%, 85%) instead of showing only the user-selected efficiency.
Changes
generateAccelChartData()andgenerateFlipBurnChartData()to acceptnozzleEfficiencyparameter and compute single mass profile instead of 4 fixed profilescreateMassRemainingDatasets()to create single dataset with dynamic label showing selected efficiency percentageBefore/After
Before: Chart always showed 4 lines regardless of selected efficiency

After: Chart shows single line matching selected efficiency with dynamic label


Implementation
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.