Skip to content

Potential fix for code scanning alert no. 10: Incorrect conversion between integer types #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lookbusy1344 merged 1 commit into from
Dec 28, 2025
Merged

Potential fix for code scanning alert no. 10: Incorrect conversion between integer types #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions encoder/data_processing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,8 @@ func (e *Encoder) encodeOperand2(cond, opcode, rn, rd, sBit uint32, operand stri
} else if opcode == opCMP {
// If CMP fails, try converting to CMN with negated value
// CMP Rn, #imm -> CMN Rn, #-imm
// #nosec G115 - intentional overflow for two's complement negation
negatedValue := uint32(-int32(value))
// Two's complement negation in uint32 domain (avoids narrowing cast)
negatedValue := ^value + 1
if negatedEncoded, negatedOk := e.encodeImmediate(negatedValue); negatedOk {
// Use CMN instead of CMP
opcode = opCMN
Expand All @@ -258,8 +258,8 @@ func (e *Encoder) encodeOperand2(cond, opcode, rn, rd, sBit uint32, operand stri
} else if opcode == opCMN {
// If CMN fails, try converting to CMP with negated value
// CMN Rn, #imm -> CMP Rn, #-imm
// #nosec G115 - intentional overflow for two's complement negation
negatedValue := uint32(-int32(value))
// Two's complement negation in uint32 domain (avoids narrowing cast)
negatedValue := ^value + 1
if negatedEncoded, negatedOk := e.encodeImmediate(negatedValue); negatedOk {
// Use CMP instead of CMN
opcode = opCMP
Expand Down
Loading