Open
Conversation
Pull in upstream
Maybe fixes disconnects
|
We are testing this - seems to work well so far so thanks! Will continue to monitor. Merging this will save a lot of time for a lot of people I imagine if #118 is solved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were having trouble with lookerbot disconnecting and not reconnecting every few days, as described in #118 .
I blindly updated botkit to 0.6.13.
We haven't needed to restart since approximately April 20 (~ 5 weeks). We haven't run into any errors.
Looks like the tests still pass. I haven't investigated throughly for breaking changes between botkit 0.0.15 and 0.6.13. It's possible this breaks something in lookerbot that we're just not using.
However, it seems like it might be a fix for the pretty painful issue #118 .
Hope this helps.