Open
Conversation
Owner
Contributor
|
This was discussed on #14 , how are you handling |
Contributor
Author
Hi, @TDHolmes! I separated std and no_std functionality by providing new What do you think about that? |
Contributor
|
Sweet! Sounds good
…On Sat, Oct 7, 2023 at 6:01 AM Nazar Demchuk ***@***.***> wrote:
This was discussed on #14
<#14> , how are you
handling drawile-rs & colored? Those are std reliant dependencies aren't
they?
Hi, @TDHolmes <https://github.com/TDHolmes>! I separated std and no_std
functionality by providing new drawille-nostd crate. Now when adding
textplots to Cargo.toml with default features (std feature enabled, no
changes required), we're using drawille and colored. Otherwise, when default-features
= false is specified, we're swithing to the functionality of the
drawille-nostd crate.
What do you think about that?
—
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5YNWR7TYKSJFAUN4EOKGLX6FHBVAVCNFSM6AAAAAA42LVWSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRG4YDOMBXGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
Thanks! Planning to test this out next week on stm32f4 =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds
no_stdfunctionality to the library. This allows for embedded development usingtextplots, although testing is needed to confirm this possibility.This is done by introducing new drawille-nostd crate, which does not rely on standard library features. Now, when adding
textplotstoCargo.tomldependencies withdefault-features = false, it will usedrawille-nostdcrate with reduced functionality (no color support):By default,
stdfeature is enabled, so you can also use all library's functionality like before, without any changes.