fix Steps plot and improve API ergonomics#58
Open
rkuhn wants to merge 2 commits intoloony-bean:masterfrom
Open
fix Steps plot and improve API ergonomics#58rkuhn wants to merge 2 commits intoloony-bean:masterfrom
rkuhn wants to merge 2 commits intoloony-bean:masterfrom
Conversation
- Steps drew up-then-right, which is not the correct visual representation of a step function with the given step points - Plot etc. traits borrowed `self` for `'a`, which is too long
rkuhn
added a commit
to input-output-hk/ouroboros-leios
that referenced
this pull request
Feb 15, 2025
there is a bug in version 0.8 in drawing step functions, should switch to official release once loony-bean/textplots-rs#58 is merged
rkuhn
added a commit
to input-output-hk/ouroboros-leios
that referenced
this pull request
Feb 16, 2025
* interim state between experiments * [delta_q] compute near/far latency profiles from topology * [delta_q] add model fitting * [delta_q] improve fit quality and output format * [delta_q] clean up and document ΔQSD analysis * small fixes * fix textplots dependency there is a bug in version 0.8 in drawing step functions, should switch to official release once loony-bean/textplots-rs#58 is merged * [delta_q] add histogram on number of hops * [delta_q] slightly better fit but worse model The issue is that it will be quite difficult to obtain reasonable load factors for using this expression in projecting resource usage. * fix textplots-rs dependency
will-break-it
pushed a commit
to input-output-hk/ouroboros-leios
that referenced
this pull request
Feb 17, 2025
* interim state between experiments * [delta_q] compute near/far latency profiles from topology * [delta_q] add model fitting * [delta_q] improve fit quality and output format * [delta_q] clean up and document ΔQSD analysis * small fixes * fix textplots dependency there is a bug in version 0.8 in drawing step functions, should switch to official release once loony-bean/textplots-rs#58 is merged * [delta_q] add histogram on number of hops * [delta_q] slightly better fit but worse model The issue is that it will be quite difficult to obtain reasonable load factors for using this expression in projecting resource usage. * fix textplots-rs dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cool library! I’m using it in Leios and found two small issues:
selffor'a, which is too long; use separate lifetime from Chartlifetime