Skip to content

Add AI Food Search to Loop Carb Interface as a Customization #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

marionbarker
Copy link
Contributor

@marionbarker marionbarker commented Jul 14, 2025

Purpose

Edited because this is now based off of Loop PR 2329 with PR 2325 closed.

This is a preliminary addition of Loop PR 2325 to the customization script.

Two PR are required: one for customization and one for lnl-scripts

Limitations

Because there are so many customizations that touch similar parts of the code, it can get hard to make all options completely independent of the inclusion of other customization items.

The patch that adds the Food Search is configured to be applied last (and removed first if removing a customization).

Order is not independent

The patch required to add PR 2329 is not independent from these 3 customizations:

  • Profile Save & Load, Basal Lock and Live Activity
  • If applied after any or all of those, all the customizations previously applied are present but a message will report that one or more of those 3 is not compatible

However, this version of the patch can be applied to a clone with no customizations or if any those 3 is already applied. That is deemed good enough for this preliminary version.

@marionbarker
Copy link
Contributor Author

marionbarker commented Aug 11, 2025

An updated version was obtained from PR 2329 with the following steps.

for more details, review these comments in PR 2329:

  1. I created a new branch hosted at loopandlearn Loop: modify_for_pr2329, which has changes required to allow the version in Taylor's repository to build, but tests do not work.

  2. I created a new branch hosted at loopandlearn Loop: prepare_for_customization_pr2329 that goes farther than modify_for_pr2329. I removed test files and Documentation files - these do not need to be part of the customization patch.

  3. The naming conventions for the patch is: pr2329_commit{from-taylor}_commit{from-prepare_for_customization_pr2329}.patch

Update method

Each time Taylor updates his original PR, I need to update these branches.

Note that while preparing this, Taylor did an update, so the version labeled: pr2329_477ca57a_c7ff2ca0.patch will soon be moved to the archive branch.

Update with new commits

When Taylor updates his branch, then I need to also update my two branches:

In a local copy of Taylor's branch:

git pull
git switch modify_for_pr2329
git merge <local-name-for-taylor's-branch>
git switch prepare_for_customization_pr2329
git merge modify_for_pr2329

This keeps the 3 version in alignment.

At that time, I can either regenerate or update the patch file for customization, depending on the details of the modification. It is typically easier to edit because there are custom edits required to modify 2 files in the patch to be compatible with some other customizations:

@marionbarker
Copy link
Contributor Author

marionbarker commented Aug 11, 2025

The customization patch was updated with Taylor's update. This modifies the default choices for each option of food search to the suggested choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants