-
Notifications
You must be signed in to change notification settings - Fork 18
Add AI Food Search to Loop Carb Interface as a Customization #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
An updated version was obtained from PR 2329 with the following steps. for more details, review these comments in PR 2329:
Update methodEach time Taylor updates his original PR, I need to update these branches. Note that while preparing this, Taylor did an update, so the version labeled: pr2329_477ca57a_c7ff2ca0.patch will soon be moved to the archive branch. Update with new commitsWhen Taylor updates his branch, then I need to also update my two branches: In a local copy of Taylor's branch:
This keeps the 3 version in alignment. At that time, I can either regenerate or update the patch file for customization, depending on the details of the modification. It is typically easier to edit because there are custom edits required to modify 2 files in the patch to be compatible with some other customizations: |
The customization patch was updated with Taylor's update. This modifies the default choices for each option of food search to the suggested choice. |
Purpose
Edited because this is now based off of Loop PR 2329 with PR 2325 closed.
This is a preliminary addition of Loop PR 2325 to the customization script.Two PR are required: one for customization and one for lnl-scripts
Limitations
Because there are so many customizations that touch similar parts of the code, it can get hard to make all options completely independent of the inclusion of other customization items.
The patch that adds the Food Search is configured to be applied last (and removed first if removing a customization).
Order is not independent
The patch required to add PR 2329 is not independent from these 3 customizations:
However, this version of the patch can be applied to a clone with no customizations or if any those 3 is already applied. That is deemed good enough for this preliminary version.