Skip to content

Conversation

@mrbatista
Copy link
Contributor

@mrbatista mrbatista commented Feb 6, 2025

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@mrbatista mrbatista force-pushed the feat/mongodb-5 branch 3 times, most recently from d4b5ba5 to 613cfe7 Compare February 6, 2025 17:20
@mrbatista
Copy link
Contributor Author

@achrinza @dhmlau Please take a look.
The only test that fail is not related to my change.

@dhmlau
Copy link
Member

dhmlau commented Feb 6, 2025

@mrbatista, thanks for the PR. Do you know if it'll be a breaking change for this connector?

Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrbatista, thanks for your contribution! LGTM

@dhmlau dhmlau merged commit cf0e199 into loopbackio:master May 23, 2025
10 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants