-
Notifications
You must be signed in to change notification settings - Fork 83
fix: do not include symbols in js-traverse #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
92cd827 to
2f3b705
Compare
|
Hi @raymondfeng, fixed the commit message lint. Thanks! |
|
@MartyJRE, I believe the commit lint issue was not fixed yet. If you squash the commits, it should be ok. |
2f3b705 to
482cf07
Compare
You're absolutely right. I blanked about the second commit. Thanks! |
|
Should I also add a new test case for symbols specifically? |
|
482cf07 to
9bb3e2b
Compare
|
@dhmlau Added tests. Sorry for the reformat, but I felt it might be good to add a test for |
9bb3e2b to
416a390
Compare
416a390 to
b96fd0d
Compare
b96fd0d to
aec7989
Compare
This commit sets `includeSymbols` to false, resulting in not throwing when calling RegExp.exec on them. Closes loopbackio#180 Signed-off-by: Martin Pražák <martin.prazak@lutherone.com>
aec7989 to
f35cae4
Compare
|
@MartyJRE, thanks for your contribution. Your PR has landed! 🎉 |
This commit sets
includeSymbolsto false, resulting in not throwing when calling RegExp.exec on them.ljharb/js-traverse#5
ljharb/js-traverse@aab373f
Fixes #180
Checklist
npm testpasses on your machine