jazzy gz vendor fixes #738
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
How do you build these pacakges? I'm getting eval error |
Contributor
Author
|
Yes, that is in https://github.com/Gepetto/gazebros2nix/blob/update_flake_lock_action/overlay.nix#L8, which is currently in a super-WIP state. |
FreeImage is insecure and was removed from nixpkgs (but we still use an older nixpkgs version with freeimage). To allow building gazebo without insecure packages, let's build ogre without it. No package fails to build, but this might cause problems at runtime. From my simple experiments with gazebo, it seems it's not the case.
It's no longer necessary to use patchGzAmentVendorGit. It tries to patch non-existent code. "Plain" patchAmentVendorGit is sufficient. Also, some manually added dependencies seem not to be needed anymore and are removed.
nim65s
force-pushed
the
gz
branch
3 times, most recently
from
e23fc11 to
d708b0a
Compare
to find OGRE-Next.pc
It thought this was already done in lopsided98#708
nim65s
force-pushed
the
gz
branch
2 times, most recently
from
8903a2a to
81ac5e4
Compare
nim65s
force-pushed
the
gz
branch
2 times, most recently
from
6609a88 to
a8eb4ee
Compare
nim65s
force-pushed
the
gz
branch
2 times, most recently
from
de46a6d to
9bfb178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here are a few patches for gz-vendor packages on jazzy.