adding support for Silence S04 with 2 batteries#18
Open
GrisuBerlin wants to merge 3 commits intolorenzo-deluca:masterfrom
Open
adding support for Silence S04 with 2 batteries#18GrisuBerlin wants to merge 3 commits intolorenzo-deluca:masterfrom
GrisuBerlin wants to merge 3 commits intolorenzo-deluca:masterfrom
Conversation
Removed conditional checks for temperature values when the scooter is not running.
|
Has this been added yet? I own an S04 with two batteries, willing to test. |
Author
|
I guess it is still not added to the release. But you can use my repo to add to home assistant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone needs to verify that it is not failing for the users where the API is not providing second battery values (for the regular scooters).