Ability to download all books in a topic#207
Open
anooprh wants to merge 2 commits intolorenzodifuccia:masterfrom
Open
Ability to download all books in a topic#207anooprh wants to merge 2 commits intolorenzodifuccia:masterfrom
anooprh wants to merge 2 commits intolorenzodifuccia:masterfrom
Conversation
|
Please resolve conflicts :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @lorenzodifuccia
Here, I am adding the functionality to
python3 safaribooks.py --cred "account_mail@mail.com:password01" --topic forexConsequently, I changed the bookid/topic being a positional argument and made it a named argument as well.
Dockerfileso that it's easier to get started.