Fix program crash by removing staticmethod decorator#320
Open
0xHanan wants to merge 7 commits intolorenzodifuccia:masterfrom
Open
Fix program crash by removing staticmethod decorator#3200xHanan wants to merge 7 commits intolorenzodifuccia:masterfrom
0xHanan wants to merge 7 commits intolorenzodifuccia:masterfrom
Conversation
- download fonts separately from CSS - scan for img tags with too many width/height specifiers and eliminate redundant ones
Introduction to API v2, thanks to @forsakenquantum 🙏🏻
Update README.md
The program crash when running with certain IDs (i.e. 9781484258811). The error message is: `[#] Unhandled Exception: name 'self' is not defined (type: NameError)` The crash occurs because the static function `fix_overconstrained_images` use `self` . The function can't use self since it's static. By removing the @staticmethod decorator the program successfully complete the download.
0xHanan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.