Merged
Conversation
- move single channel logic to webSocket struct - split client and server into separate files - add a utility optTicker - add support for bidirectional ping pong Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
xBlaz3kx
reviewed
Feb 22, 2025
10 tasks
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
0a809d7 to
d94a48d
Compare
xBlaz3kx
approved these changes
Mar 1, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Refactors the package to improve code structure, abstracting away some functionality and also allow for new features to be added on top more easily.
Included changes:
webSocketnow includes most of the actual communication logic, including:server.goandclient.gowebSocketstruct for actual communication, streamlining the channel logic and removing some duplicate codeTypes of changes
Checklist