Conversation
240fb49 to
41f7684
Compare
41f7684 to
7bb906a
Compare
|
Ill need a couple of reviewers to double check my work - if all the fields are mapped, named and validated correctly. |
|
Hi xBlaz3kx, I noticed that the DynUpdateTime field of ocpp2.1 ChargingProfile is of type DateTime from ocpp2.0.1/types. |
28be971 to
775710e
Compare
Hey, thanks for pointing it out! Even though this wouldnt be a cricital issue, it is nice to have everything correctly referenced :) |
|
Hi, thanks for working on this OCPP 2.1 feature — it’s great to see progress on supporting the newer extensions. I’m currently working on a charging station project that aims to use a large subset of OCPP 2.1 features (including scenarios combined with ISO 15118-2/20). While evaluating this PR and comparing the Go types against the official OCPP 2.1 JSON schemas, I noticed a few discrepancies that will likely need to be addressed for schema compliance. In particular:
All of the above is based on the OCPP 2.1 JSON schemas, and I might have missed some context, so please feel free to correct me if that’s the case. I’m very interested in this work and in helping bring ocpp-go closer to production readiness. If you’re open to it, I’d be happy to help by preparing fixes or aligning parts of this PR more closely with the specification — just let me know what contribution approach would work best for you. Thanks! |
Hey, thanks for pointing out these discrepancies! I'll take a look as soon as I can. I'm also more actively working on my own fork of this repo - feel free to contribute there as well. |
Proposed changes
OCPP 2.1:
OCPPJ:
Misc:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.