Skip to content

Conversation

@dwibudut
Copy link
Contributor

Proposed changes

  • Fix type of field GetCertificateStatusResponse.Status to types.Certificate15118EVStatus instead of types.GenericStatus
  • Add omitempty to certificateType field base on doc. spec requirement
  • Also fix panic nil pointer confirmation.StatusInfo.ReasonCode in unit test TestGetCompositeScheduleE2EMocked

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Fix type of field GetCertificateStatusResponse.Status to types.Certificate15118EVStatus instead of types.GenericStatus:
image

Add omitempty to certificateType field on GetInstalledCertificateIdsRequest base on doc. spec:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant