fix: align CompositeSchedule struct with OCPP 2.0.1 spec#411
Open
rishabhvaish wants to merge 1 commit intolorenzodonini:masterfrom
Open
fix: align CompositeSchedule struct with OCPP 2.0.1 spec#411rishabhvaish wants to merge 1 commit intolorenzodonini:masterfrom
rishabhvaish wants to merge 1 commit intolorenzodonini:masterfrom
Conversation
The CompositeScheduleType had incorrect fields (StartDateTime + ChargingSchedule) that didn't match the official OCPP 2.0.1 JSON schema. Replaced with the five required fields: EvseID, Duration, ScheduleStart, ChargingRateUnit, and ChargingSchedulePeriod. Added NewCompositeSchedule constructor and updated tests to validate the corrected structure including negative cases for missing required fields. Fixes lorenzodonini#385
Contributor
|
Duplicate of #386 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CompositeSchedulestruct was wrong — it hadStartDateTimeandChargingSchedulefields, but the OCPP 2.0.1 JSON schema forCompositeScheduleTypeactually defines a flat structure withevseId,duration,scheduleStart,chargingRateUnit, andchargingSchedulePeriodas required fields.I've fixed the struct to match the spec exactly and added a
NewCompositeScheduleconstructor for convenience. The validation and E2E tests are updated accordingly, with new negative test cases for missing required fields.Note: this is a breaking change since the struct fields are completely different. Code using
CompositeSchedule{StartDateTime: ..., ChargingSchedule: ...}will need to switch to the new fields.Fixes #385
Types of changes
Checklist