Skip to content

Conversation

@BjarkeHautop
Copy link
Contributor

@BjarkeHautop BjarkeHautop commented Nov 7, 2025

Arguments were listed with - instead of _, which is inconsistent with the actual hook implementation (see lintr.R).

This also clarifies what the --load_package argument does and when it should be used.

As an improvement, the default hook generation could include --load_package for {lintr} by default, and suggest that users call snippet_generate("additional-deps-lintr"), similar to how the roxygenize hook works.

For context, see the related issue: #647.

@BjarkeHautop
Copy link
Contributor Author

BjarkeHautop commented Nov 7, 2025

snippet_generate("additional-deps-lintr") should probably also include suggested dependencies, so {lintr} works on readme, vignettes, and articles.

@lorenzwalthert lorenzwalthert merged commit 994e2d0 into lorenzwalthert:main Nov 8, 2025
14 checks passed
@lorenzwalthert
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants