Fix 11 bugs in polymarket market maker bot#2
Open
jme21 wants to merge 1 commit intolorine93s:mainfrom
Open
Conversation
Critical fixes: - Fix invalid orderbook validation (best_ask <= 1 -> best_ask >= 1) - Fix async/sync mismatch in WebSocket handler using inspect.iscoroutinefunction - Add inventory update mechanism via trade handler Medium fixes: - Fix division by zero in get_quote_size_no when price >= 1.0 - Fix WebSocket reconnection to resubscribe to all channels - Fix wrong cancelled count in batch_cancel_orders - Fix pending cancellations memory leak by cleaning up after single cancels Minor fixes: - Fix load_dotenv() order (move before get_settings) - Add metrics recording for orders, fills, cancellations, spread - Fix WebSocket type hint (WebSocketClientProtocol instead of Server) - Remove unused imports (Any, BaseModel) from config.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical fixes:
Medium fixes:
Minor fixes: