Feat: LoroTree #16
Merged
Feat: LoroTree #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h creates
- Add onCreate callback to tree-create changes (diff.ts) to:
- write the assigned TreeID back into the new state node
- retarget queued child creates’ parent to the freshly created parent ID
- Apply tree creates in order and invoke onCreate immediately after createNode (mirror.ts)
to ensure children receive the correct parent ID in the same update
- Document Tree create ordering & IDs in README with example (incl. Chinese note)
- Improve type checks: isValueOfContainerType recognizes array shapes for List/Tree (utils.ts)
- Add comments and optional debug divergence check for Tree updates (mirror.ts)
- Update tests for tree behavior and quoting consistency
Rationale: users cannot know new TreeIDs ahead of time; when creating a parent and its children
together, the parent’s ID is unknown at diff time. The onCreate hook backfills IDs and patches
child parent references to keep state and Loro in sync without rebuilding entire subtrees.
This was referenced Sep 12, 2025
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.