Skip to content

feat: add onWsClose callback to LoroWebsocketClient options #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Leeeon233 merged 1 commit into from
Sep 11, 2025
Merged

feat: add onWsClose callback to LoroWebsocketClient options #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/loro-websocket/src/client/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class LoroWebsocketClient {
}> = [];

constructor(
private ops: { url: string; pingIntervalMs?: number; disablePing?: boolean }
private ops: { url: string; pingIntervalMs?: number; disablePing?: boolean, onWsClose?: () => void }
) {
this.connectedPromise = new Promise<void>((resolve, reject) => {
this.ws = new WebSocket(this.ops.url);
Expand Down Expand Up @@ -100,6 +100,7 @@ export class LoroWebsocketClient {
// Clear timers and pending waiters on close
this.ws.addEventListener('close', () => {
this.clearPingTimer();
this.ops.onWsClose?.();
this.rejectAllPingWaiters(new Error("WebSocket closed"));
});
}
Expand Down