-
Notifications
You must be signed in to change notification settings - Fork 4
feat!: protocol v1 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Upgrade the protocol to v1
DocUpdateso peers can correlate acknowledgments.Ack(0x08) to positively confirm or reject updates; v0 relied onUpdateErrormessages and had no explicit success signal.UpdateErrortoRoomError, which evicts the peer from the room until it rejoins.okis now0x00,unknownmoves to0x01, and the remaining codes keep their numeric values from v0.RoomErrormeans the peer will stop receiving room traffic unless it performs a new join handshake.Why these changes (v1)
Ackfor each update batch (or fragment batch) lets applications know whether a change was accepted instead of inferring success from silence.RoomErrordistinguishes "your update failed" from "you are no longer in the room", enabling clients to stop syncing and prompt rejoin or escalation.okto0x00andunknownto0x01aligns status bytes with common success/failure conventions and leaves room for app-specific errors.