Open
Conversation
added 6 commits
November 17, 2015 12:05
…for updating roi points also now deletes the temporary template used for updated roi points.
…es the shape object that's held by the active tool, removes it from the list of items of the plot, and then resets the active tool. ROIs that may been drawn but were not saved to the ROI List prior to updating the shape of another ROI are no longer deleted as a result of the update_roi method.
…ctions only affect ROI deletion or ROI shape updates. Added classes for these commands to establish how to handle undo and redo calls.
Member
|
Thanks @angelc134. That looks great. It looks like this also includes #22 though, so we need to resolve that one first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canceling the deletion of an ROI was a feature missing from the ROI Buddy GUI. These changes handle both the undo calls and the redo calls for deleting an ROI object by adding the "delete an ROI" command to an undoStack. I've also added the ability to handle undo/redo calls for updating the shape of an ROI.