I made PacketTracer more bearable for myself, is any of this interesting to you? #26
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| *.deb | ||
| *.flatpak | ||
| build/ | ||
| repo/ | ||
| .flatpak-builder/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,29 @@ | ||
| app-id: com.cisco.PacketTracer | ||
| runtime: org.kde.Platform | ||
| runtime-version: '6.8' | ||
| sdk: org.kde.Sdk | ||
| base: io.qt.qtwebengine.BaseApp | ||
| base-version: '6.8' | ||
| command: /app/pt/packettracer | ||
| separate-locales: false | ||
|
|
||
| tags: | ||
| - proprietary | ||
|
|
||
| finish-args: | ||
| # - --share=ipc | ||
|
Owner
There was a problem hiding this comment. I think removing this could potentially negatively impact performance1. Footnotes |
||
| # - --share=network | ||
|
Owner
There was a problem hiding this comment. I think we should keep this otherwise I don't believe it's possible to login with your Cisco account. |
||
| - --socket=x11 | ||
| # - --socket=pulseaudio | ||
|
Owner
There was a problem hiding this comment. I don't remember there being any audio output from Packet Tracer lol, so it's fine to remove this. |
||
| - --device=dri | ||
| # - --filesystem=xdg-download | ||
|
Owner
There was a problem hiding this comment. The reason I added was so that I had somewhere I could save the session file. Most Flatpak's are meant to be usable out of the box and if you want it more restricted, I think the best way to do this is to have the user do so from Flatseal before they launch the Flatpak. |
||
| - --persist=. | ||
| - --env=TZ= | ||
| - --nofilesystem=xdg-config/kdeglobals | ||
|
Owner
There was a problem hiding this comment. Fine as long as you can confirm this doesn't break anything on KDE1. Footnotes |
||
| - --no-talk-name=com.canonical.AppMenu.Registrar | ||
|
Owner
There was a problem hiding this comment. Fine as long as you can confirm this doesn't remove this functionality. |
||
| - --no-talk-name=org.kde.kconfig.notify | ||
| - --no-talk-name=org.kde.kdeconnect | ||
| - --no-talk-name=org.kde.KGlobalSettings | ||
|
|
||
| modules: | ||
| - name: packettracer | ||
|
|
@@ -35,13 +40,16 @@ modules: | |
| - install -D com.cisco.PacketTracer.png /app/share/icons/hicolor/128x128/apps/com.cisco.PacketTracer.png | ||
| - install -D com.cisco.PacketTracer.desktop /app/share/applications/com.cisco.PacketTracer.desktop | ||
| - install -D com.cisco.PacketTracer.url.desktop /app/share/applications/com.cisco.PacketTracer.url.desktop | ||
| - patch /app/pt/packettracer packettracer.patch | ||
| - sed -i -e 's\/opt/\/app/\g' /app/pt/packettracer /app/pt/linguist | ||
| - sed -i -e 's\"$@"\-style windows "$@"\;' /app/pt/packettracer /app/pt/linguist | ||
|
|
||
| sources: | ||
| - type: file | ||
| path: Packet_Tracer822_amd64_signed.deb | ||
| sha256: 6cd2b8891df92d2cad8b6fdc47480fc089de085c4f3fe95eb80d5450a2a7f72d | ||
| - type: file | ||
| path: packettracer.patch | ||
| - type: file | ||
| path: com.cisco.PacketTracer.appdata.xml | ||
| - type: file | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| @@ -5,5 +5,5 @@ | ||
| PTDIR=/opt/pt | ||
| export LD_LIBRARY_PATH=/opt/pt/bin | ||
| pushd /opt/pt/bin > /dev/null | ||
| -./PacketTracer "$@" > /dev/null 2>&1 | ||
| +./PacketTracer "$@" | ||
| popd > /dev/null |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat, I didn't realise you could do this! It's probably better if you just remove this step and move this command to replace the existing
flatpak-builder buildcommand in step 5.