Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions com.cisco.PacketTracer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,19 @@ tags:
- proprietary

finish-args:
- --share=ipc
- --share=network
# - --share=ipc
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think removing this could potentially negatively impact performance1.

Footnotes

  1. https://docs.flatpak.org/en/latest/sandbox-permissions.html#f1

# - --share=network
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep this otherwise I don't believe it's possible to login with your Cisco account.

- --socket=x11
- --socket=pulseaudio
# - --socket=pulseaudio
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember there being any audio output from Packet Tracer lol, so it's fine to remove this.

- --device=dri
- --filesystem=xdg-download
# - --filesystem=xdg-download
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I added was so that I had somewhere I could save the session file. Most Flatpak's are meant to be usable out of the box and if you want it more restricted, I think the best way to do this is to have the user do so from Flatseal before they launch the Flatpak.

- --persist=.
- --env=TZ=
- --nofilesystem=xdg-config/kdeglobals
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine as long as you can confirm this doesn't break anything on KDE1.

Footnotes

  1. https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/1786

- --no-talk-name=com.canonical.AppMenu.Registrar
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine as long as you can confirm this doesn't remove this functionality.

- --no-talk-name=org.kde.kconfig.notify
- --no-talk-name=org.kde.kdeconnect
- --no-talk-name=org.kde.KGlobalSettings

modules:
- name: packettracer
Expand Down