Skip to content

fix(types): update autoOrient type to include undefined#4362

Merged
lovell merged 1 commit intolovell:mainfrom
styfle:patch-2
Apr 4, 2025
Merged

fix(types): update autoOrient type to include undefined#4362
lovell merged 1 commit intolovell:mainfrom
styfle:patch-2

Conversation

@styfle
Copy link
Copy Markdown
Contributor

@styfle styfle commented Apr 4, 2025

This PR fixes the following error:

node_modules/sharp/lib/index.d.ts(1590,15): error TS2430: Interface 'OverlayOptions' incorrectly extends interface 'SharpOptions'.
  Types of property 'autoOrient' are incompatible.
    Type 'boolean | undefined' is not assignable to type 'boolean'.
      Type 'undefined' is not assignable to type 'boolean'.

The bug was introduced in:

This PR fixes the following error:

```
node_modules/.pnpm/sharp@0.34.0/node_modules/sharp/lib/index.d.ts(1590,15): error TS2430: Interface 'OverlayOptions' incorrectly extends interface 'SharpOptions'.
  Types of property 'autoOrient' are incompatible.
    Type 'boolean | undefined' is not assignable to type 'boolean'.
      Type 'undefined' is not assignable to type 'boolean'.
```
@styfle
Copy link
Copy Markdown
Contributor Author

styfle commented Apr 4, 2025

I discovered this when updating vercel/next.js here:

cc @lovell

@lovell lovell merged commit 3c7dbb8 into lovell:main Apr 4, 2025
22 checks passed
@lovell lovell added this to the v0.34.1 milestone Apr 4, 2025
@lovell
Copy link
Copy Markdown
Owner

lovell commented Apr 4, 2025

Thank you Steven!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants