fix(types): Add missing properties for animated images#4369
Merged
lovell merged 1 commit intolovell:mainfrom Apr 12, 2025
Merged
fix(types): Add missing properties for animated images#4369lovell merged 1 commit intolovell:mainfrom
lovell merged 1 commit intolovell:mainfrom
Conversation
Owner
|
Thank you very much Steven! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This PR is to add two missing properties to
sharp.OutputInfothat are present for animated images. Comments are copied from the same properties insharp.Metadata.The test
Animated GIF round tripintest/unit/gif.jsreferences them (link), so it does seem intentional for them to be part of the OutputInfo.This is my first PR for the project, so please let me know if you need more information from me.
Thanks for all the hard work on this library!