-
Notifications
You must be signed in to change notification settings - Fork 1
Tidy up the repository to be published to Pypi #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
33cad63 to
08e2242
Compare
Signed-off-by: Douglas Reis <[email protected]>
Signed-off-by: Douglas Reis <[email protected]>
b1d1d5e to
6a6314a
Compare
machshev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good! This will be a huge improvement, thanks.
Some nits, but up to you what you take from them.
| executionEnvironments = [ | ||
| { root = "src" }, | ||
| ] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no ruff tool config here. Which is fine if the defaults are okay, but it might be worth explicitly specifying in case the defaults change?
| packages = ["src/rdlexporter"] | ||
| requires = ["uv_build>=0.8.4,<0.9.0"] | ||
| build-backend = "uv_build" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here about the ruff config.
| [tool.setuptools] | ||
| py-modules = [] | ||
|
|
||
| [tool.ruff] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed you have the ruff config here. If the LSPs pick this up okay then great! Might be worth checking they don't stop at the package level pyproject.toml when discovering the ruff config.
A quick test could be to set the line length to 10 or something and then run ruff inside one of the package directories?
Actually I guess the IDE may pick up the pyproject.toml from the root of the repo first? Not sure, but it might be worth opening neovim from the context of a subdir within a package and then again at the repo root and see if there is a difference in terms of rule discovery.
Signed-off-by: Douglas Reis <[email protected]>
Signed-off-by: Douglas Reis <[email protected]>
Signed-off-by: Douglas Reis <[email protected]>
Signed-off-by: Douglas Reis <[email protected]>
Signed-off-by: Douglas Reis <[email protected]>
This PR prepares the two packages hosted in this repository to be published in pypi.
This is how the published package will look like in Pypi:
https://test.pypi.org/project/rdlexporter/
https://test.pypi.org/project/rdl2ot/