refactor: [job] pull out JobTime tests, improved testing and fix a few bugs #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machshev
requested review from
andreaskurth,
hcallahan-lowrisc and
rswarbrick
machshev
force-pushed
the
job-time
branch
2 times, most recently
from
89a5755 to
1c579fc
Compare
rswarbrick
reviewed
Sep 23, 2025
Contributor
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
Some nits, but it looks good to me otherwise!
rswarbrick
approved these changes
Sep 23, 2025
…w bugs Signed-off-by: James McCorrie <[email protected]>
Disable rule that wants long exception error messages to be defined in the Error class itself. This makes some sense for custom error classes. However it's not appropriate to define custom error classes for every different error case. Generally a common error class is used in such cases, for example `RuntimeError` and `ValueError`. Signed-off-by: James McCorrie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JobTime still has unit tests in the same module as the class, move these out to the tests directory.
Migrate from
unittesttests and instead use pytest.Fixed some issues with the implementation and refactored based on issues raised while expanding the test cases.
This PR brings up the total unit test coverage metric to 5%.