-
Notifications
You must be signed in to change notification settings - Fork 4
ci: Setup automated python-semantic-release action #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Setup automated python-semantic-release action #41
Conversation
machshev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @hcallahan-lowrisc!
As you say it looks like concurrency could be an issue, the docs are not clear on what the actual behaviour is. But it looks like concurrency groups only support one waiting workflow/job. So if a 3rd PRs get merged before the first release workflow is finished then the 2nd workflow is killed.
If we reduce the concurrency group scope to just the job that calculates the release version number (which is a lot quicker than the full workflow), then this could mitigate such an issue.
efa3064 to
c4c7856
Compare
c4c7856 to
499e054
Compare
|
This is now ready for review/approval, though please do not merge as I need to setup the repo configuration beforehand (TODOs), and ensure the CA will correctly issue a token. |
machshev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also expand the set of python packages available in the default flake package to all dependencies (mandatory and optional) in the Python project. Signed-off-by: Harry Callahan <[email protected]>
Signed-off-by: Harry Callahan <[email protected]>
Signed-off-by: Harry Callahan <[email protected]>
…onventional commits Signed-off-by: Harry Callahan <[email protected]>
Signed-off-by: Harry Callahan <[email protected]>
Signed-off-by: Harry Callahan <[email protected]>
Signed-off-by: Harry Callahan <[email protected]>
Signed-off-by: Harry Callahan <[email protected]>
499e054 to
6f33644
Compare
Expand the the release.yml workflow to cut new dvsim releases using python-semantic-release if a merged pull request contains commits that follow the configured conventional-commit formatting.
Some examples from deployments on my personal fork
There is still some TODOs here, and I would appreciate some reviews as GHA is not something I am extremely confident about, but it's definitely ready for review.
Opens:
How do multiple in-flight merges in close sucession behave? There is a 'concurrency' attribute in the first job, but I'm not sure if this is sufficient. Also, how might we test for issues here?Todo:
Also follow-up opens in my mind:
After this is merged, I suggest we use it to cut a 1.0.0 release :)
Closes #5