[Scheduler] refactor to improve the scheduler deploy object coupling #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James McCorrie <[email protected]>
Update the scheduler to index the deployment object mappings by `deploy.full_name` instead of the `deploy` object itself. This means that the `Deploy` object does not need to be "hash-able". The `full_name` now takes account of the variant, as without this the deployment objects are not uniquely identifiable from the "full name". From what I can tell the only use of the `full_name` attribute is for logs and for unique IDs, which turns out not to be unique enough. Signed-off-by: James McCorrie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the scheduler to index the deployment object mappings by
deploy.full_nameinstead of thedeployobject itself. This means that theDeployobject does not need to be "hash-able".The
full_namenow takes account of the variant, as without this the deployment objects are not uniquely identifiable from the "full name". From what I can tell the only use of thefull_nameattribute is for logs and for unique IDs, which turns out not to be unique enough.