ci: fix python matrix #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that by default uv creates a venv using the system python version, despite explicitly asking it to install a different version of python. Which means that the test matrix was always using 3.12 which is the version github pre-install on their CI runner VM image. Signed-off-by: James McCorrie <[email protected]>
machshev
force-pushed
the
fix-ci-matrix
branch
from
0143d08 to
b681376
Compare
Signed-off-by: James McCorrie <[email protected]>
Signed-off-by: James McCorrie <[email protected]>
hcallahan-lowrisc
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that by default uv creates a venv using the system python version, despite explicitly asking it to install a different version of python. Which means that the test matrix was always using 3.12 which is the version github pre-install on their CI runner VM image.
Some fixes are required to get the CI to pass on versions 3.10 - 3.14:
rm_pathtests to better cover the behaviours and then remove use offollow_symlinks=argument inPath.exists().With these fixes the CI now passes and correctly runs the tests with the expected versions of python.