-
Notifications
You must be signed in to change notification settings - Fork 4
Report cli with report gen from historic data #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: James McCorrie <[email protected]>
Signed-off-by: James McCorrie <[email protected]>
| @@ -1,5 +1,5 @@ | |||
| version = 1 | |||
| revision = 3 | |||
| revision = 2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the revision number went backward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, probably another PR did a UV lock and got in before this I one.
I can rebase on master and relock in this PR.
It should be fine either way though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have noticed the same here https://github.com/lowRISC/dvsim/pull/64/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's the UV lock format version. So my guess is the version of UV being used in some of the branches is slightly older.
It shouldn't make a difference either way. But I'll rebase and relock and see if that keeps the version the same.
This file is auto-generated by the UV tool. There are no manual changes in it. The changes that drive lock file changes are either:
- changing dependencies
pyproject.toml - relocking with later versions - which we should be doing periodically anyway.
The UV.lock format is internal to the tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried rebasing and relocking, also nix flake update. It still seems to like revision 2 using the locked nix devshell version of uv. It might be that previously I somehow locked with a later version?
Given this is an internal file format and it is still functional, I'm going to merge this as it is.
Signed-off-by: James McCorrie <[email protected]>
To help developing DVSim report templates, add a command that can generate reports from the JSON data of a previous run.
argparsecli.py->cli/run.pyclickbased shim which wraps the existing CLIUpdate
Tried using a click shim and initially it seemed to work, but the existing
dvsimcli has a positional argument (the hjson config) which makes the parsing unreliable. I can't get it to work withclickandargparsemix without bumping the existingdvsimcli to a sub command e.g.dvsim-->dvsim run.Reverting to the original idea of creating a separate
dvsim-adminclick CLI. This can be easily merged back in in the future if we make the CLI breaking change.Fixes: #59