[ibex_register_file_fpga] Drop two confusing comments#2250
Merged
rswarbrick merged 1 commit intolowRISC:masterfrom Jan 23, 2025
Merged
[ibex_register_file_fpga] Drop two confusing comments#2250rswarbrick merged 1 commit intolowRISC:masterfrom
rswarbrick merged 1 commit intolowRISC:masterfrom
Conversation
These were noticed by someone responding to issue lowRISC#2230. I think the author's original logic was to point out that there's a path from e.g. raddr_a_i to rdata_a_o which doesn't depend on any clock, so is "asynchronous". But that's the same in the other modes and also for the other register file implementations, which don't have analogous comments. Drop these ones.
nasahlpa
approved these changes
Jan 23, 2025
Member
nasahlpa
left a comment
nasahlpa
left a comment
There was a problem hiding this comment.
Ah yeah, makes sense. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were noticed by someone responding to issue #2230. I think the author's original logic was to point out that there's a path from e.g. raddr_a_i to rdata_a_o which doesn't depend on any clock, so is "asynchronous".
But that's the same in the other modes and also for the other register file implementations, which don't have analogous comments.
Drop these ones.