[ibex] Pass mvendorid and mimpid as top-level params #2267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razer6
force-pushed
the
ibex-mvendorid-mimpid-param
branch
from
6f9651b to
af2f400
Compare
Contributor
|
This looks good to me, thanks. I looked into the CI failure and can't see how it relates to your changes, so I assume it’s a quirk of our current (older) Verilator version. I created a PR addressing this failure here: #2270. If that gets merged, CI should be fixed and this PR should be good to go, IMO. If we decide not to implement the fix, we could disable the linter on the specific line where Verilator is currently complaining. |
Razer6
force-pushed
the
ibex-mvendorid-mimpid-param
branch
from
af2f400 to
7c85b9f
Compare
Contributor
andreaskurth
left a comment
andreaskurth
left a comment
There was a problem hiding this comment.
Two small comments, otherwise LGTM
Razer6
force-pushed
the
ibex-mvendorid-mimpid-param
branch
from
7c85b9f to
cbade62
Compare
Instead of using default values from a package, create a top-level parameter to define these and pass them down. This allows integrators to specify them on a per-instance basis. Signed-off-by: Robert Schilling <rschilling@rivosinc.com>
Razer6
force-pushed
the
ibex-mvendorid-mimpid-param
branch
from
cbade62 to
66ca376
Compare
andreaskurth
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using default values from a package, create a top-level parameter to define these and pass them down. This allows integrators to specify them on a per-instance basis.