[rtl] Minor tweak to decoder to avoid dead code#2269
Merged
andreaskurth merged 1 commit intolowRISC:masterfrom Apr 25, 2025
Merged
[rtl] Minor tweak to decoder to avoid dead code#2269andreaskurth merged 1 commit intolowRISC:masterfrom
andreaskurth merged 1 commit intolowRISC:masterfrom
Conversation
The "else" part of the if/else check here wasn't possible because the surrounding else branch (starting at line 406) is already in the case where instr[26] is zero.
Contributor
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
This makes sense to me. Is it worth plopping an assertion that instr[26] must be zero if the code gets here?
Contributor
Author
|
I don't think so, since it's visible "syntactically". And we don't really have procedural assertions in our RTL code, I don't think. And I don't think I know a clever way to fake it for this sort of thing? |
andreaskurth
approved these changes
Apr 25, 2025
Contributor
andreaskurth
left a comment
andreaskurth
left a comment
There was a problem hiding this comment.
LGTM, thx @rswarbrick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "else" part of the if/else check here wasn't possible because the surrounding else branch (starting at line 406) is already in the case where instr[26] is zero.
Fixes #2268.