Skip to content

Conversation

@ShadowBearVR
Copy link
Contributor

This change updates the C++ language version to C++17, project wide. Previously, C++14 was used.

The same update is being made to OpenTitan via lowRISC/opentitan#27530.

This change updates the C++ language version to C++17, project wide.

Signed-off-by: Collin MacDonald <[email protected]>
@timothytrippel timothytrippel marked this pull request as ready for review July 1, 2025 22:31
@cfrantz
Copy link

cfrantz commented Jul 1, 2025

Don't we also need to add this to .bazelrc?

# https://opentitan.org/book/doc/contributing/style_guides/c_cpp_coding_style.html#c-version specifies
build --action_env=BAZEL_CXXOPTS="-std=gnu++17"
build --cxxopt='-std=gnu++17'
build --conlyopt='-std=gnu11'

@luismarques
Copy link
Contributor

Don't we also need to add this to .bazelrc?

# https://opentitan.org/book/doc/contributing/style_guides/c_cpp_coding_style.html#c-version specifies
build --action_env=BAZEL_CXXOPTS="-std=gnu++17"
build --cxxopt='-std=gnu++17'
build --conlyopt='-std=gnu11'

What do you mean? The Ibex repo itself doesn't use Bazel. That was added on lowRISC/opentitan#27530 for the OT side of things.

@luismarques luismarques requested a review from vogelpi July 2, 2025 11:03
@cfrantz
Copy link

cfrantz commented Jul 2, 2025

What do you mean? The Ibex repo itself doesn't use Bazel. That was added on lowRISC/opentitan#27530 for the OT side of things.

NVM; I though it was for opentitan/master; I didn't realize this was for Ibex.

@timothytrippel timothytrippel added this pull request to the merge queue Jul 2, 2025
Merged via the queue into lowRISC:master with commit e5b8d05 Jul 2, 2025
11 checks passed
@ShadowBearVR ShadowBearVR deleted the cpp17-upgrade branch July 2, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants