[nix] bring formal environment up-to-date #2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not actually need to build the sail model, we just need the source code for formal. Signed-off-by: Gary Guo <[email protected]>
This updates sail to a commit that is compatible with OCaml 5.0. The updated sail also include a commit to include unreachable_loc already so related parts is dropped from buildspec.py. Signed-off-by: Gary Guo <[email protected]>
Signed-off-by: Gary Guo <[email protected]>
mndstrmr
approved these changes
Jul 28, 2025
Contributor
mndstrmr
left a comment
mndstrmr
left a comment
There was a problem hiding this comment.
Awesome, thanks for the cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates nixpkgs to 25.05 and bring sail to the latest of lowrisc branch (which is needed as the old commit is not compatible with OCaml 5).
I have verified the change with Jasper and it still proves.