[sw,cryptolib] Update ECC random scalar gen function header #28612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-filali
added
the
CherryPick:earlgrey_1.0.0
sw/otbn/crypto/p256_base.s
Outdated
| * d = (d0 + d1) mod n | ||
| * ...where n is the curve order. | ||
| * | ||
| * This implementation follows FIPS 186-4 section B.4.1, where we |
There was a problem hiding this comment.
should we update this as well?
There was a problem hiding this comment.
Yes I think so, thanks for flagging this @johannheyszl !
There was a problem hiding this comment.
Yes definitely, thanks!
There was a problem hiding this comment.
Can you please check the PR again @h-filali ? I can't see this change. Only the p384 file is modified currently.
There was a problem hiding this comment.
@vogelpi you're right. It's added now.
sw/otbn/crypto/p256_base.s
Outdated
| * d = (d0 + d1) mod n | ||
| * ...where n is the curve order. | ||
| * | ||
| * This implementation follows FIPS 186-4 section B.4.1, where we |
There was a problem hiding this comment.
Suggested change
| * This implementation follows FIPS 186-5 section A.2.1, where we |
2 tasks
h-filali
force-pushed
the
cryptolib-update-ecc-random-scalar-header
branch
from
2817b23 to
086b5b1
Compare
|
I rebased and addressed the comments. Thanks for reviewing @johannheyszl ! |
andrea-caforio
approved these changes
Oct 31, 2025
|
Thanks @johannheyszl @andrea-caforio. Merging this. |
This commit updates the ECC random secret scalar generation function header. I checked the implementation for FIPS 186-5 compliance and updated the header comment accordingly. Signed-off-by: Hakim Filali <[email protected]>
h-filali
force-pushed
the
cryptolib-update-ecc-random-scalar-header
branch
from
086b5b1 to
012d8ae
Compare
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the ECC random secret scalar generation function header.
I checked the implementation for FIPS 186-5 compliance and updated the header comment accordingly.
In case anyone wants to double check: FIPS 186-5