[CODEOWNERS] Remove msf from codeowners file #28632
Conversation
Razer6
force-pushed
the
rm-msf-from-codeowners
branch
from
5a0ca1c to
9640e9e
Compare
Razer6
changed the title
Razer6
force-pushed
the
rm-msf-from-codeowners
branch
from
9640e9e to
87ebc7c
Compare
There are automatic reviewer assignments based on the codeowners file. msf is not attached to the project anymore. So it's quite annoying to get PRs automatically assigned to him. Probably for him as well. Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
rm-msf-from-codeowners
branch
from
87ebc7c to
a094604
Compare
|
I think this will probably need some discussion, partly because I don't think there's an agreed definition of what inclusion in CODEOWNERS means! I've scheduled a discussion at the next TC meeting (on Thursday 6th November). About MSF being added as a reviewer to some PRs: I'm not sure I can see any downside to anyone who isn't controlling his inbox :-) I agree that it would be annoying if a random person got added to e.g. |
To my knowledge, OpenTitan currently has no concept of a code owner. There was an RFC last year, but no agreement was reached. That said, the CODEOWNERS file is currently used solely to control the automatic assignment of reviewers to PRs. It's bad and also annoying to get msf on around 80% of the PRs assigned, although he is not actively working on the project anymore. I might know about this fact. Others not necessarily and then wait for a review. |
2 participants
There are automatic reviewer assignments based on the codeowners file. msf is not attached to the project anymore. So it's quite annoying to get PRs automatically assigned to him. Probably for him as well.