Cherry-pick to earlgrey_1.0.0: [cryptotest] Fix some failing RSA verify cryptotests #28661
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wycheproof testvector seem to have a leading 0. This means that a 512-byte modulo for RSA-4096 is actually 513-byte. Currently, the test framework fails because it expects a 512-byte value. Remove this leading 0. Signed-off-by: Pascal Nasahl <[email protected]> (cherry picked from commit e134cd0)
Some tests in the wycheproof test vector set are error tests. In one of these error tests, a larger signature (514 instead of 512-bytes) is sent to the DUT. However, we currently limit the signature payload to 512- bytes, letting the test fail. The solution to this is simple, increase the max. number of signature bytes to 512-bytes. The CL now gets this 514-byte signature and internally fails, as expected by the test. Signed-off-by: Pascal Nasahl <[email protected]> (cherry picked from commit 9ab2711)
lowrisc-ci
bot
requested review from
engdoreis and
jwnrt
and removed request for
a team
nasahlpa
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #28655 to branch
earlgrey_1.0.0.